This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Correctly scope imagePullSecrets by their namespace #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR fluxcd#2520 broke the scoping of imagePullSecrets when allowing to get workloads from all namespaces at once. The problem is that a secret cache (`seenCreds`) was indexed by the secret name (making it namespace specific). Processing all the namespaces at once without adjusting the scoping opened the door to clashes between secrets from different namespaces which are called the same.
hiddeco
approved these changes
Jan 8, 2020
This was referenced Jan 10, 2020
2opremio
added a commit
that referenced
this pull request
Feb 12, 2020
When merging the gitops PoC code a the bugfix at #2728 was incorrectly overwritten.
2opremio
added a commit
that referenced
this pull request
Feb 14, 2020
When merging the gitops PoC code a the bugfix at #2728 was incorrectly overwritten.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2520 broke the scoping of imagePullSecrets when allowing to get workloads from all namespaces at once.
The problem is that a secret cache (
seenCreds) was indexed by the secret name (making it namespace specific).Processing all the namespaces at once without adjusting the scoping opened the door to clashes between secrets from different namespaces which are called the same.
Fixes #2723