This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Make pkg/install a Go module to reduce its dependencies #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
changed the title
2opremio
force-pushed
the
add-submodule-for-install
branch
from
0e5043d to
8a86d36
Compare
added 2 commits
January 26, 2020 21:29
External projects (like github.com/weaveworks/eksctl, which in turn are used as a library) shouldn't need to pull the full Flux dependencies by only using `pkg/install`.
2opremio
force-pushed
the
add-submodule-for-install
branch
from
8a86d36 to
e9b39c3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External projects (like github.com/weaveworks/eksctl, which in turn are used as a library) shouldn't need to pull the full Flux dependencies by only using
pkg/install.This will cause a million conflicts with #2776 but I wanted to try it ASAP.
Fix: #2779