This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Roll back Kustomize to v3.8.7 #3504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingdonb
force-pushed
the
revert-kustomize-3-8-10
branch
from
b30133a to
17253dc
Compare
kingdonb
pushed a commit
to spron-in/flux
that referenced
this pull request
Jul 21, 2021
kingdonb
force-pushed
the
revert-kustomize-3-8-10
branch
from
17253dc to
eb6c5ae
Compare
hiddeco
approved these changes
Jul 22, 2021
added 2 commits
July 22, 2021 08:52
According to #3500, there are breaking changes in the patch release of Kustomize v3.8.8 which were included in the Flux 1.23.0 release that upgraded from Kustomize v3.8.4 to v3.8.10. A PATCH or MINOR release in semver is meant to signal that compatibility is maintained, but it appears the semver wasn't totally honest and a behavior was changed in a destructive way for some users. Other Flux users were looking (#3457) for functionality that was added in v3.8.5, (so I guess that could have been our first clue semver isn't strictly honored) rather than revert the update entirely, we'd like to at least upgrade that far. Signed-off-by: Kingdon Barrett <kingdon@weave.works>
kingdonb
force-pushed
the
revert-kustomize-3-8-10
branch
from
eb6c5ae to
f9fe2ab
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #3500, there are breaking changes in the patch release of Kustomize v3.8.8 which were included in the Flux 1.23.0 release that upgraded from Kustomize v3.8.4 to v3.8.10.
A PATCH or MINOR release in semver is meant to signal that compatibility is maintained, but it appears the semver wasn't totally honest and a behavior was changed in a destructive way for some users.
Other Flux users were looking (#3457) for functionality that was added in v3.8.5, (so I guess that could have been our first clue semver isn't strictly honored) rather than revert the update entirely, we'd like to at least maintain the upgrade that far.