Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flux components Go v1.17 upgrade #2016

Closed
10 tasks done
relu opened this issue Oct 27, 2021 · 9 comments
Closed
10 tasks done

Flux components Go v1.17 upgrade #2016

relu opened this issue Oct 27, 2021 · 9 comments
Labels
area/ci CI related issues and pull requests

Comments

@relu
Copy link
Member

relu commented Oct 27, 2021

This is an umbrella issue to keep track of the Go version upgrade work across all of the Flux components.

@stefanprodan
Copy link
Member

We may want to delay this as Go 1.17 mod doesn't work with x/crypto packages.

@relu relu added the blocked/upstream Blocked by an upstream dependency or issue label Oct 27, 2021
@relu
Copy link
Member Author

relu commented Oct 27, 2021

Got it, thanks for the information. We can use this when the time comes.

@stefanprodan stefanprodan changed the title Flux components golang v1.17 upgrade Flux components Go v1.17 upgrade Oct 27, 2021
@stefanprodan
Copy link
Member

I see that some issues were fixed, e.g. golang/go#46761

I propose we test the upgrade in source-controller and make sure the multi-arch build works.

@relu relu removed the blocked/upstream Blocked by an upstream dependency or issue label Oct 27, 2021
@stefanprodan
Copy link
Member

Let's block this until Kubernetes client-go and controller-runtime switch to Go 1.17 https://github.com/kubernetes-sigs/controller-runtime/blob/master/go.mod

@relu
Copy link
Member Author

relu commented Nov 9, 2021

Sounds good to me.

@stefanprodan
Copy link
Member

So Kubernetes has switched to Go 1.17 for compiling but go.mod is still on 1.16 format. I propose we do the same, bump Go in CI and in the Dockerfiles to 1.17, leave go.mod as it.

@relu
Copy link
Member Author

relu commented Dec 5, 2021

@stefanprodan I'm not sure if that applies to our repos. I tried to search for a reason why they decided to do that and found two relevant comments here and here. It looks like this is just because the reporting tools they use are not (yet?) supporting the dependency graph information that go mod 1.17 handles.

On a side note, controller-runtime has the mod changes in place in master right now but there's not yet a released version containing the change if we're still waiting for that to happen.

@stefanprodan
Copy link
Member

stefanprodan commented Dec 14, 2021

controller-runtime with Go .1.7 has been released https://github.com/kubernetes-sigs/controller-runtime/blob/v0.11.0/go.mod#L3

@relu Can you update controller-runtime in fluxcd/pkg and rebase your PR? I'm for getting this in now.

@stefanprodan stefanprodan removed the blocked/upstream Blocked by an upstream dependency or issue label Dec 14, 2021
@relu
Copy link
Member Author

relu commented Dec 14, 2021

@stefanprodan definitely, I'll get to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests
Projects
None yet
Development

No branches or pull requests

2 participants