-
Notifications
You must be signed in to change notification settings - Fork 17
Relocate top navigation event handling outside of the view #63
Conversation
@adberger that you for this PR. We decided to wait with the Go 1.17 upgrade until our upstream dependencies (controller-runtime, helm, kstatus, etc) are aligned. Please see: fluxcd/flux2#2016 |
@stefanprodan Is there a reason to do this, even if it works for this project? |
Yes we want to have an homogeneous build system, using Go 1.17 in webui that consumes various Flux packages that are pinned on Go 1.16 is not desirable. |
Okay then, I removed the upgrade to go version 1.17 |
@kingdonb can you take a look at it? |
@adberger LGTM. However, can you please update the PR title have a more detailed description of what it contains: 'fixes context names dropdown bug' or something similar. Adding a note that this is based on a larger PR by @chanwit here: #57 @stefanprodan This works and can be merged I believe |
Signed-off-by: Adrian <adrian.berger@bedag.ch>
@adberger please rebase with upstream main and force push. |
@stefanprodan Is this way (merge from main into this branch) ok too? |
Cherry picked from #57: