Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Relocate top navigation event handling outside of the view #63

Closed
wants to merge 2 commits into from
Closed

Relocate top navigation event handling outside of the view #63

wants to merge 2 commits into from

Conversation

adberger
Copy link
Contributor

@adberger adberger commented Nov 15, 2021

Cherry picked from #57:

  • Relocate top navigation event handling outside of the view
  • Some formatting changes
  • Some spelling changes

@stefanprodan
Copy link
Member

@adberger that you for this PR. We decided to wait with the Go 1.17 upgrade until our upstream dependencies (controller-runtime, helm, kstatus, etc) are aligned. Please see: fluxcd/flux2#2016

@adberger
Copy link
Contributor Author

@stefanprodan Is there a reason to do this, even if it works for this project?
Just asking out of curiosity

@stefanprodan
Copy link
Member

Is there a reason to do this, even if it works for this project?

Yes we want to have an homogeneous build system, using Go 1.17 in webui that consumes various Flux packages that are pinned on Go 1.16 is not desirable.

@adberger
Copy link
Contributor Author

Is there a reason to do this, even if it works for this project?

Yes we want to have an homogeneous build system, using Go 1.17 in webui that consumes various Flux packages that are pinned on Go 1.16 is not desirable.

Okay then, I removed the upgrade to go version 1.17

@adberger
Copy link
Contributor Author

@kingdonb can you take a look at it?

@juozasg
Copy link

juozasg commented Nov 19, 2021

@adberger LGTM. However, can you please update the PR title have a more detailed description of what it contains: 'fixes context names dropdown bug' or something similar.

Adding a note that this is based on a larger PR by @chanwit here: #57

@stefanprodan This works and can be merged I believe

@adberger adberger changed the title Cherry pick/57 Relocate top navigation event handling outside of the view Nov 20, 2021
@adberger
Copy link
Contributor Author

@juozasg Thanks for your comment. The context dropdown bug was already fixed and merged, see #59
But I changed the title & description of this PR, so I hope this is good now.

Signed-off-by: Adrian <adrian.berger@bedag.ch>
@stefanprodan
Copy link
Member

@adberger please rebase with upstream main and force push.

@adberger
Copy link
Contributor Author

adberger commented Nov 21, 2021

@stefanprodan Is this way (merge from main into this branch) ok too?

@tellbow tellbow closed this by deleting the head repository Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants