Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tk sync example from help command #131

Merged
merged 3 commits into from
Jul 26, 2020
Merged

Remove tk sync example from help command #131

merged 3 commits into from
Jul 26, 2020

Conversation

mmorejon
Copy link
Contributor

Remove tk sync example from help command

@mmorejon
Remove tk sync example from help command
d245ef9 
Signed-off-by: Manuel Morejon <manuel@mmorejon.io>
hiddeco
hiddeco reviewed Jul 25, 2020
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! sync has been renamed recently to reconcile, given this I think it would be better to change the example.

hiddeco
hiddeco reviewed Jul 25, 2020
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, to resolve the CI failure: please run make api-docs after making the change and before committing the changes to align the generated docs with the updated examples.

@mmorejon
Copy link
Contributor Author

In addition, to resolve the CI failure: please run make api-docs after making the change and before committing the changes to align the generated docs with the updated examples.

I used make docs, the entry api-docs doesn't appear in the Makefile.

hiddeco
hiddeco approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mmorejon 🌷

@hiddeco hiddeco merged commit db23c8c into fluxcd:master Jul 26, 2020
ybelleguic pushed a commit to ybelleguic/flux2 that referenced this pull request Jan 9, 2023
@racdev
libgit2: Configured libgit2 clone ProxyOptions
3d276b6 
This configures ProxyOptions for all libgit2 Checkout functions when
cloning and configures the options based on current environment
settings using the git2go.ProxyTypeAuto option.

Refs: fluxcd#131
Signed-off-by: Robert Clarke <rob@robertandrewclarke.com>
Co-authored-by: Aurélien GARNIER <aurelien.garnier@atos.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmorejon @hiddeco