Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progressbar and checks to roadmap md #134

Merged
merged 3 commits into from
Jul 30, 2020
Merged

Add progressbar and checks to roadmap md #134

merged 3 commits into from
Jul 30, 2020

Conversation

bia
Copy link
Contributor

@bia bia commented Jul 29, 2020

Resolves #132

Screenshot 2020-07-29 at 21 08 48

@stefanprodan
Copy link
Member

@bia can we have a progressbar per milestone?

hiddeco
hiddeco reviewed Jul 30, 2020
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙌

Minor nitpick comment.

docs/roadmap/index.md Outdated Show resolved Hide resolved
@bia
Copy link
Contributor Author

bia commented Jul 30, 2020

@bia can we have a progressbar per milestone?

@stefanprodan You mean like this?
Screenshot 2020-07-30 at 12 22 41

@stefanprodan
Copy link
Member

I would place the progressbar after each milestone title instead of listing them twice.

@bia
Copy link
Contributor Author

bia commented Jul 30, 2020

Great idea!
Screenshot 2020-07-30 at 12 59 33

stefanprodan
stefanprodan approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @bia 🌷

@bia
Copy link
Contributor Author

bia commented Jul 30, 2020

Thanks ☀️

but I can't unsee the second line misalignment.
Got to fix after my meetings or tomorrow.

@bia
Copy link
Contributor Author

bia commented Jul 30, 2020

Fixed. 🙂
Screenshot 2020-07-30 at 21 57 05

hiddeco
hiddeco approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bia 🌞🍰

@hiddeco hiddeco merged commit 50d2eb7 into fluxcd:master Jul 30, 2020
@hiddeco hiddeco added the area/docs Documentation related issues and pull requests label Jul 30, 2020
@dholbach
Copy link
Member

Beautiful work! <3

ybelleguic pushed a commit to ybelleguic/flux2 that referenced this pull request Jan 9, 2023
@hiddeco
Merge pull request fluxcd#134 from fluxcd/artifact-api-improvements
ec51eda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/docs Documentation related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Beautify roadmap md
4 participants
@bia @stefanprodan @dholbach @hiddeco