Add checksum verification to install script #24 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Aug 19, 2020
hiddeco
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
Looks great, awesome improvements @mberwanger 🌷
Can you please smash your commits together (with a commit description that sums up the changes) so that the history in master stays clean? Thanks in advance.
hiddeco
added
area/install
stefanprodan
approved these changes
Aug 20, 2020
- add checksum verification with sha256sum fallback to shasum - add downloader fallback to wget - add os and architecture checks
|
I squashed the commits and it should be good to go. |
|
Excellent, thanks a lot (again) @mberwanger 🥝 |
ybelleguic
pushed a commit
to ybelleguic/flux2
that referenced
this pull request
Jan 9, 2023
Set default branch to main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for checksum verification