Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document targetPath in Helm Releases guide #167

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Document targetPath in Helm Releases guide #167

merged 1 commit into from
Aug 20, 2020

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Aug 20, 2020

No description provided.

@hiddeco hiddeco added the area/docs Documentation related issues and pull requests label Aug 20, 2020
squaremo
squaremo approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads well 👍. I shuffled a couple of sentences around to avoid a dangling preposition. I think examples would go a long way for the targetPath thing.

docs/guides/helmreleases.md Outdated Show resolved Hide resolved
docs/guides/helmreleases.md Outdated Show resolved Hide resolved
docs/guides/helmreleases.md Outdated Show resolved Hide resolved
@hiddeco hiddeco added the area/helm Helm related issues and pull requests label Aug 20, 2020
@hiddeco hiddeco merged commit 479d757 into master Aug 20, 2020
@hiddeco hiddeco deleted the guide-helm-targetpath branch August 20, 2020 13:28
ybelleguic pushed a commit to ybelleguic/flux2 that referenced this pull request Jan 9, 2023
@stefanprodan
Merge pull request fluxcd#167 from fluxcd/docs-add-ns
369e078 
Add namespace to API docs examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squaremo squaremo squaremo approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/docs Documentation related issues and pull requests area/helm Helm related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiddeco @squaremo @stefanprodan