Fix: change v1.JSON for HelmRelease to pointer #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
approved these changes
Aug 31, 2020
As the HelmRelease injects its own HelmChart, the first reconciliation will always trigger a `Ready==False` condition while it waits for the chart to become ready. Given this, we should only take this condition into account when the `status.LastAttemptedRevision` has been recorded, as this marks the fact that the chart is available and an action was attempted.
hiddeco
added
area/helm
ybelleguic
pushed a commit
to ybelleguic/flux2
that referenced
this pull request
Jan 9, 2023
Add finalizers to RBAC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix follow up on #184.