-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kustomize: use FS from fluxcd/pkg
#2651
Conversation
fc4fe70
to
3f1b920
Compare
We need to postpone this until @stefanprodan is back next week, as I currently can't steer around some of the assumptions (and lack of a root argument) in some of the generating parts of the API. |
ca77155
to
c2041fe
Compare
6f9850f
to
2e6f576
Compare
2e6f576
to
b6c8dea
Compare
c24ae3b
to
0259bc0
Compare
This switches to a secure FS implementation in most places, except for where we can not make changes at this moment because it would break behavior. Not handled in this commit: - Allowing the root for `manifestgen` packages to be configured. - Allowing the user to define a working root while building locally. - Defaulting to the secure FS implementation in `kustomization.MakeDefaultOptions`. Problem here is that constructing the secure FS could result in an error, which we can not surface without signature changes to the constructor func. Signed-off-by: Hidde Beydals <hello@hidde.co>
0259bc0
to
57442e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this @hiddeco! 👏 👏
LGTM
This switches to a secure FS implementation in most places, except for
where we can not make changes at this moment because it would break
behavior.
Not handled in this commit:
manifestgen
packages to be configured.kustomization.MakeDefaultOptions
. Problem here is that constructingthe secure FS could result in an error, which we can not surface
without signature changes to the constructor func.