use data field in Secrets
#2795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are some bugs in stringData, and it's better to just use data Signed-off-by: Max Jonas Werner <mail@makk.es>
|
While Kubernetes has issues with Please raise issues for things like this before PRs. Thanks! |
|
@stefanprodan this was a follow-up to @souleb's ask here so I didn't think an issue was necessary. 🤔 |
|
Using data in flux does not guard against stringData used by users in their repos. Also using data in Flux, would prevent secret scanners from notifying users they push credentials to Git, since the values are base64. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are some bugs in stringData, and it's better to just use data