Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC-0002] Add auth specification for Helm OCI #3025

Merged
merged 1 commit into from
Aug 25, 2022
Merged

[RFC-0002] Add auth specification for Helm OCI #3025

merged 1 commit into from
Aug 25, 2022

Conversation

stefanprodan
Copy link
Member

Add basic auth and contextual login for AWS, Azure, GCP to the Helm OCI RFC.

@stefanprodan stefanprodan added the area/rfc Feature request proposals in the RFC format label Aug 24, 2022
@stefanprodan stefanprodan mentioned this pull request Aug 24, 2022
Merged
3 tasks
makkes
makkes reviewed Aug 24, 2022
View reviewed changes
rfcs/0002-helm-oci/README.md Show resolved Hide resolved
rfcs/0002-helm-oci/README.md Show resolved Hide resolved
@darkowlzz
Copy link
Contributor

darkowlzz commented Aug 24, 2022 •
edited
Loading

Maybe off-topic but felt like it's related to authentication in a way, the change in fluxcd/source-controller#856 to allow authenticating with the registry domain without path to chart, can we also document that here? Or in a separate PR if it's off-topic. I'm afraid that it's not documented anywhere and may become a hidden feature.

@stefanprodan
[RFC-0002] Add auth specification for Helm OCI
07de9d9 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Copy link
Member Author

I'm afraid that it's not documented anywhere and may become a hidden feature.

@darkowlzz I think this should be in the API spec doc.

@souleb
Copy link
Member

souleb commented Aug 25, 2022

Reading this:

When not specified, the spec.type field defaults to default which preserve the current HelmRepository API behaviour.

We don't actually have this in the code, we would need to add // +kubebuilder:default:=default.

darkowlzz
darkowlzz approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanprodan
Copy link
Member Author

@souleb we do have the default implemented in code but not in CRD, which is fine.

@stefanprodan stefanprodan merged commit c454dd4 into main Aug 25, 2022
@stefanprodan stefanprodan deleted the rfc-0002-auth branch August 25, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjbgf pjbgf pjbgf left review comments

@hiddeco hiddeco hiddeco left review comments

@makkes makkes makkes approved these changes

@darkowlzz darkowlzz darkowlzz approved these changes

Assignees
No one assigned
Labels
area/rfc Feature request proposals in the RFC format
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stefanprodan @darkowlzz @souleb @makkes @pjbgf @hiddeco