Add a dry-run mode to flux build kustomization #3317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
The reason to this is because MakeSecureFSOnDisk is not consistent between OS. Signed-off-by: Soule BA <soule@weave.works>
souleb
force-pushed
the
update-pkg-kustomize
branch
from
3f9dfcb to
ce3688b
Compare
souleb
force-pushed
the
update-pkg-kustomize
branch
from
ce3688b to
e514b3e
Compare
souleb
force-pushed
the
update-pkg-kustomize
branch
2 times, most recently
from
7bd769e to
482cf09
Compare
If implemented user will be able to use `flux build kustomization` without any connection to the cluster. Signed-off-by: Soule BA <soule@weave.works>
souleb
force-pushed
the
update-pkg-kustomize
branch
from
482cf09 to
ad5daee
Compare
stefanprodan
added
the
area/kustomization
hiddeco
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Given the introduction of the secure FS was more to ensure the behavior between controller and CLI was the same, rather than offering a real security layer (which is more up to the OS and user space in non multi-tenant environments). I am fine with these changes.
Thanks @souleb 🙇
|
so I assume this will be included into the next release? do you mind sharing when is the next release (approx)? |
|
Verified fixed in 0.37.0. Had the same issue as #2785 in 0.36.0 |
|
yep, works on 0.37.0 for me as well |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Soule BA soule@weave.works
fixes #2785
This is has to be merged after fluxcd/pkg#392.
If implemented user will be able to use
flux build kustomizationwithout any connection to the cluster.This also revert the use of
MakeSecureFSOnDisk, mainly because it is not consistent between OS. It was also not used in theflux/pkg/kustomizegenerator, so it was still possible to by-pass the enforcement.