Add GITHUB_TOKEN to Flux GitHub Action #3501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add ability to auth to github api docs: add authentication snippet example docs: update checkout@v3, create-pull-request@v4 docs: add documentation about the github token secret Review: Add suggested change from last week (per fluxcd#3474 (comment)) Signed-off-by: Erik Kristensen <erik@erikkristensen.com> Signed-off-by: Kingdon Barrett <kingdon@weave.works>
kingdonb
force-pushed
the
flux-action-updates
branch
from
fac1982 to
8ff8295
Compare
stefanprodan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, the PR in #3474 is still blocked
I'm going to rebase and squash, but here's a reference to the original commit I made which adds just one change to the existing PR is:
fac1982
to make the review easier, you might want to check that one first.
c7a4876
is 1538522 rebased against the current main branch without any other changes
I noticed that this doesn't only affect flux update job which runs hourly, but can even impact GitHub actions jobs that embed the "install flux" action inline!
Trying to get this unblocked, I've added the one suggestion from #3474 (comment) rebased and resubmitted this PR so that it can merge.
I'm going to go ahead and pre-emptively squash all the commits, as well, to simplify the merge.
Fix: #3455