Fix broken GitHub Action and handle case where VERSION is provided as an input #3517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realized my commit is marked as "unverified". Thought I had signed it, will update it... |
If VERSION is provided, VERSION_SLUG will never be set and VERSION will be overwritten with a bad value. Signed-off-by: Joel Guedj <joel.guedj@gmail.com>
jooooel
force-pushed
the
joel/fix-bug-in-action
branch
from
4f5e507 to
5b422be
Compare
Closed
|
Thank you @jooooel you beat me to it, I think I'll hang up my Bash shoes for a while. Congrats first-time contributor here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was introduced in ed13067, when trying to solve this issue: #3509.
If
VERSIONis provided,VERSION_SLUGwill never be set andVERSIONwill be overwritten with a bad value.