Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add bootstrap gitea command #4270

Merged
merged 1 commit into from
Nov 1, 2023
Merged

feat: add bootstrap gitea command #4270

merged 1 commit into from
Nov 1, 2023

Conversation

Azhovan
Copy link
Contributor

@Azhovan Azhovan commented Sep 20, 2023 •
edited
Loading

This PR implement bootstrap gitea command feature requested here: #4080

output:

 ./bin/flux bootstrap gitea --owner Azhovan --repository test3       
► connecting to gitea.com
► cloning branch "main" from Git repository "https://gitea.com/Azhovan/test3.git"
✔ cloned repository
► generating component manifests
✔ generated component manifests
✔ committed sync manifests to "main" ("a5860ca2f6919d98874461d97e6495f03e22b67e")
► pushing component manifests to "https://gitea.com/Azhovan/test3.git"
► installing components in "flux-system" namespace
✔ installed components
✔ reconciled components
► determining if source secret "flux-system/flux-system" exists
► generating source secret
✔ public key: ecdsa-sha2-nistp384 AAAAE2VjZHNhLXNoYTItbmlzdHAzzDQAAAAIbmlzdHAzODQAAABhBEN2Y/IZhv0aDh1zy1lhdlGPUjE01Eg5WgMtPwMFn9womCxMTR4tZDHgevQ0/xhrNblr4rUVPlqLEaKmbJX28sbOeKb4UKm5X2LDYv2YFTg1X1tXK0TOs48X4onWgdZyug==
✔ configured deploy key "flux-system-main-flux-system" for "https://gitea.com/Azhovan/test3"
► applying source secret "flux-system/flux-system"
✔ reconciled source secret
► generating sync manifests
✔ generated sync manifests
✔ committed sync manifests to "main" ("b2616e147e2fece39fba2e7eef7ccafe134be09e")
► pushing sync manifests to "https://gitea.com/Azhovan/test3.git"
► applying sync manifests
✔ reconciled sync configuration
◎ waiting for Kustomization "flux-system/flux-system" to be reconciled
✔ Kustomization reconciled successfully
► confirming components are healthy
✔ helm-controller: deployment ready
✔ kustomize-controller: deployment ready
✔ notification-controller: deployment ready
✔ source-controller: deployment ready
✔ all components are healthy

@Azhovan Azhovan force-pushed the jabar/add-gitea-bootstrapper branch from 29a39fc to e0b09c6 Compare September 20, 2023 21:29
@takirala takirala mentioned this pull request Sep 20, 2023
Closed
@Azhovan Azhovan force-pushed the jabar/add-gitea-bootstrapper branch 2 times, most recently from 0f2b0f0 to b8dcfcb Compare September 21, 2023 08:59
@Azhovan Azhovan changed the title feat: add gitea bootstrapper feat: add bootstrap gitea command Sep 21, 2023
@Azhovan
Copy link
Contributor Author

Azhovan commented Sep 21, 2023

ping @makkes

@makkes
Copy link
Member

makkes commented Sep 25, 2023

I haven't looked at the PR in detail, yet but it generally looks good. What we need in addition is a PR at fluxcd/website to add a Gitea-specific page under https://fluxcd.io/flux/installation/bootstrap/.

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 25, 2023
View reviewed changes
pkg/bootstrap/provider/factory.go Fixed Show resolved Hide resolved
@makkes makkes mentioned this pull request Sep 26, 2023
Closed
@Azhovan
Copy link
Contributor Author

Azhovan commented Sep 26, 2023

I haven't looked at the PR in detail, yet but it generally looks good. What we need in addition is a PR at fluxcd/website to add a Gitea-specific page under https://fluxcd.io/flux/installation/bootstrap/.

sure, I will create a PR there as well.

@Azhovan Azhovan mentioned this pull request Sep 27, 2023
Merged
@Azhovan
Copy link
Contributor Author

Azhovan commented Sep 27, 2023

I haven't looked at the PR in detail, yet but it generally looks good. What we need in addition is a PR at fluxcd/website to add a Gitea-specific page under https://fluxcd.io/flux/installation/bootstrap/.

Added here: fluxcd/website#1676

@Azhovan Azhovan force-pushed the jabar/add-gitea-bootstrapper branch 2 times, most recently from 421e1ad to 3c1640e Compare September 27, 2023 13:35
@Azhovan
Copy link
Contributor Author

Azhovan commented Oct 5, 2023

@makkes
is there any thing that need to be done here?

@makkes
Copy link
Member

makkes commented Oct 27, 2023

Sorry for the delay @Azhovan. @somtochiama and I tested it and it works as expected. I'll see why the CI check is failing, probably just re-run it and merge the PR as soon as everything's green. Then we can go over the website PR.

@makkes makkes force-pushed the jabar/add-gitea-bootstrapper branch from 3c1640e to a945b89 Compare October 27, 2023 10:54
@Azhovan Azhovan force-pushed the jabar/add-gitea-bootstrapper branch from a945b89 to 2593591 Compare November 1, 2023 13:08
@makkes
Copy link
Member

makkes commented Nov 1, 2023

@Azhovan please don't merge main into this branch but rebase instead.

@Azhovan Azhovan force-pushed the jabar/add-gitea-bootstrapper branch 2 times, most recently from 95e9c36 to cb9d829 Compare November 1, 2023 13:16
@Azhovan
Copy link
Contributor Author

Azhovan commented Nov 1, 2023 •
edited
Loading

@Azhovan please don't merge main into this branch but rebase instead.

I just rebased, can we run the checks again to see if its failing or has been fixed? 🤔

@Azhovan
Copy link
Contributor Author

Azhovan commented Nov 1, 2023 •
edited
Loading

actually I think i can run e2e pipeline also in my fork

@Azhovan
Copy link
Contributor Author

Azhovan commented Nov 1, 2023 •
edited
Loading

From what I think the e2e is failing only because go mod files are not updated(aka directory is dirty),
I will update them by running make test locally and push changes

@Azhovan
Copy link
Contributor Author

Azhovan commented Nov 1, 2023 •
edited
Loading

nevertheless it wont fail on my fork https://github.com/Azhovan/flux2/actions/runs/6720222904/job/18263324685

@makkes lets please re-run the job one more time, I think this should fix it

@Azhovan Azhovan force-pushed the jabar/add-gitea-bootstrapper branch from 1a0e8ac to 3851044 Compare November 1, 2023 13:37
@makkes
Copy link
Member

makkes commented Nov 1, 2023

Please squash your commits before we can merge.

@Azhovan Azhovan force-pushed the jabar/add-gitea-bootstrapper branch from 3851044 to a97a856 Compare November 1, 2023 14:46
@Azhovan
feat: add gitea bootstrapper
dcbca6b 
Signed-off-by: Jabar Asadi <jasadi@d2iq.com>
@Azhovan Azhovan force-pushed the jabar/add-gitea-bootstrapper branch from a97a856 to dcbca6b Compare November 1, 2023 14:46
@Azhovan
Copy link
Contributor Author

Azhovan commented Nov 1, 2023

Please squash your commits before we can merge.

Thanks, sure,

e2e looked green by the way!

@stefanprodan stefanprodan added enhancement New feature or request area/bootstrap Bootstrap related issues and pull requests labels Nov 1, 2023
@makkes makkes merged commit e7c015d into fluxcd:main Nov 1, 2023
9 checks passed
@stefanprodan stefanprodan mentioned this pull request Nov 16, 2023
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makkes makkes makkes approved these changes

Assignees
No one assigned
Labels
area/bootstrap Bootstrap related issues and pull requests enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Azhovan @makkes @stefanprodan