-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bootstrap gitea command #4270
Conversation
29a39fc
to
e0b09c6
Compare
0f2b0f0
to
b8dcfcb
Compare
ping @makkes |
I haven't looked at the PR in detail, yet but it generally looks good. What we need in addition is a PR at fluxcd/website to add a Gitea-specific page under https://fluxcd.io/flux/installation/bootstrap/. |
sure, I will create a PR there as well. |
Added here: fluxcd/website#1676 |
421e1ad
to
3c1640e
Compare
@makkes |
Sorry for the delay @Azhovan. @somtochiama and I tested it and it works as expected. I'll see why the CI check is failing, probably just re-run it and merge the PR as soon as everything's green. Then we can go over the website PR. |
3c1640e
to
a945b89
Compare
a945b89
to
2593591
Compare
@Azhovan please don't merge |
95e9c36
to
cb9d829
Compare
I just rebased, can we run the checks again to see if its failing or has been fixed? 🤔 |
actually I think i can run e2e pipeline also in my fork |
From what I think the e2e is failing only because go mod files are not updated(aka directory is dirty), |
nevertheless it wont fail on my fork https://github.com/Azhovan/flux2/actions/runs/6720222904/job/18263324685 @makkes lets please re-run the job one more time, I think this should fix it |
1a0e8ac
to
3851044
Compare
Please squash your commits before we can merge. |
3851044
to
a97a856
Compare
Signed-off-by: Jabar Asadi <jasadi@d2iq.com>
a97a856
to
dcbca6b
Compare
Thanks, sure, e2e looked green by the way! |
This PR implement
bootstrap gitea
command feature requested here: #4080output: