[RFC-0006] Flux-CDEvent Receiver #4534
Conversation
There was a problem hiding this comment.
LGTM
We have discussed the CDEvents proposal at Flux dev meetings and I volunteer to sponsor this RFC. Thanks @adamkenihan 🏅
rfcs/NNNN-cdevents/README.md
Outdated
| resources: | ||
| - kind: Kustomization | ||
| apiVersion: kustomize.toolkit.fluxcd.io/v1 | ||
| name: podinfo | ||
| namespace: flux-system |
There was a problem hiding this comment.
We should use here a GitRepository, triggering the Kustomization would do nothing. Receivers are for telling Flux to pull changes from upstream sources, then Flux knows how to notify the appliers (Kustomizations and HelmReleases).
There was a problem hiding this comment.
For clarity, this is how Flux eventing works
|
Many of the above requested changes have been added if you would like to review the RFC again. |
There was a problem hiding this comment.
This doesn't seem to be used anywhere.
There was a problem hiding this comment.
@adamkenihan can you remove this file?
There was a problem hiding this comment.
I will remove it when I mark the RFC ready for implementation.
adamkenihan
force-pushed
the
RFC
branch
2 times, most recently
from
66a1dce
to
44a8033
Compare
stefanprodan
changed the title
|
@adamkenihan I have assigned |
stefanprodan
changed the title
adamkenihan
force-pushed
the
RFC
branch
2 times, most recently
from
4343873
to
05411ac
Compare
Signed-off-by: adamkenihan <adam.kenihan@est.tech> Create CDEvents RFC Signed-off-by: adamkenihan <adam.kenihan@est.tech> Update README.md Signed-off-by: adamkenihan <adam.kenihan@est.tech> Add files via upload Signed-off-by: adamkenihan <adam.kenihan@est.tech> Edits to diagrams Signed-off-by: adamkenihan <adam.kenihan@est.tech> Update README.md Signed-off-by: adamkenihan <adam.kenihan@est.tech> Add files via upload Signed-off-by: adamkenihan <adam.kenihan@est.tech> Update README.md Signed-off-by: adamkenihan <adam.kenihan@est.tech> Improvements to rfcs/NNNN-cdevents/README.md Signed-off-by: adamkenihan <adam.kenihan@est.tech> Add CDEvents Receiver RFC Signed-off-by: adamkenihan <adam.kenihan@est.tech> Add CDEvents Receiver RFC Signed-off-by: adamkenihan <adam.kenihan@est.tech> Add CDEvents Receiver RFC Signed-off-by: adamkenihan <adam.kenihan@est.tech> Small tweaks to cdevents RFC Signed-off-by: adamkenihan <adam.kenihan@est.tech> change cdevents RFC yaml example format Signed-off-by: adamkenihan <adam.kenihan@est.tech> Add CDEvents Receiver RFC Signed-off-by: adamkenihan <adam.kenihan@est.tech> Create CDEvents RFC Signed-off-by: adamkenihan <adam.kenihan@est.tech> Signed-off-by: adamkenihan <adam.kenihan@est.tech> Change RFC number Signed-off-by: adamkenihan <adam.kenihan@est.tech> Update rfcs/0006-cdevents/README.md Signed-off-by: adamkenihan <adam.kenihan@est.tech> Update README.md Signed-off-by: adamkenihan <adam.kenihan@est.tech> Update rfcs/0006-cdevents/README.md Signed-off-by: adamkenihan <adam.kenihan@est.tech> Update rfcs/0006-cdevents/README.md Signed-off-by: adamkenihan <adam.kenihan@est.tech> Co-Authored-By: Sunny <github@darkowlzz.space> Co-Authored-By: souleb <bah.soule@gmail.com>
This RFC proposes to add a
receiverthat supports receiving and validatingCDEventsin order to reconcile resources.