Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use patch instead of update when adding finalizers #395

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Use patch instead of update when adding finalizers #395

merged 1 commit into from
Jan 14, 2022

Conversation

kingdonb
Copy link
Member

Following example of fluxcd/source-controller#542

Use patch instead of update when adding finalizers
0498e9e 
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
@kingdonb kingdonb mentioned this pull request Jan 14, 2022
Merged
stefanprodan
stefanprodan approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @kingdonb

@stefanprodan stefanprodan merged commit 0246b7d into fluxcd:main Jan 14, 2022
@kingdonb kingdonb deleted the patch-finalizers branch January 14, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingdonb @stefanprodan