release: reset recorded failure cond on dry-run

fluxcd · Apr 22, 2020 · d2c8711 · d2c8711
1 parent cf0480a
commit d2c8711
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/pkg/apis/helm.fluxcd.io/v1/types_helmrelease.go b/pkg/apis/helm.fluxcd.io/v1/types_helmrelease.go
@@ -498,8 +498,8 @@ const (
 	HelmReleasePhaseInstalling HelmReleasePhase = "Installing"
 	// Upgrading means the upgrade for the HelmRelease is running.
 	HelmReleasePhaseUpgrading HelmReleasePhase = "Upgrading"
-	// Succeeded means the installation or upgrade for the HelmRelease
-	// succeeded.
+	// Succeeded means the dry-run, installation, or upgrade for the
+	// HelmRelease succeeded.
 	HelmReleasePhaseSucceeded HelmReleasePhase = "Succeeded"
 	// Failed means the installation or upgrade for the HelmRelease
 	// failed.

diff --git a/pkg/release/release.go b/pkg/release/release.go
@@ -267,6 +267,7 @@ next:
 			action = UpgradeAction
 			goto next
 		}
+		status.SetStatusPhase(r.hrClient.HelmReleases(hr.Namespace), hr, v1.HelmReleasePhaseSucceeded)
 		logger.Log("info", "no changes", "phase", action)
 	case InstallAction:
 		logger.Log("info", "running installation", "phase", action)