Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Documented defaults for createCRD don't match actuals #34

Closed
dcherman opened this issue Aug 21, 2019 · 1 comment · Fixed by #35
Closed

Documented defaults for createCRD don't match actuals #34

dcherman opened this issue Aug 21, 2019 · 1 comment · Fixed by #35
Labels
blocked needs validation In need of validation before further action bug Something isn't working

Comments

@dcherman
Copy link
Contributor

Hi,

The documented defaults for createCRD don't match what's in values.yaml

helm-operator/chart/helm-operator/values.yaml

Line 13 in 6bfd9fa

createCRD: false

https://github.com/fluxcd/helm-operator/blob/6bfd9fa8a87f686ddbac8332ae5e1eb9cee6893e/chart/helm-operator/README.md#configuration

Happy to make a PR correcting this, just need to know which value you intended to be the default
@dcherman dcherman added blocked needs validation In need of validation before further action bug Something isn't working labels Aug 21, 2019
@stefanprodan
Copy link
Member

The default should be set to false

dcherman added a commit to dcherman/helm-operator that referenced this issue Aug 21, 2019
@dcherman
Correct the documented default for createCRD
5dcf0ff 
Fixes fluxcd#34
@dcherman dcherman mentioned this issue Aug 21, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocked needs validation In need of validation before further action bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct the documented default for createCRD dcherman/helm-operator
2 participants
@dcherman @stefanprodan