This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
release: detect change of charts base values #182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #174
From my investigation I found that upon running the dry-run we compare to see if the release values have changed but never actually checked to see if the charts base values themselves actually changed.
This adds a checksum of the chart values to the Chart type which in turn leads to the chart comparison to see a difference resulting in a release to occur when the base charts values are changed.
I also did some slight refactoring to move the existing Checksum logic into the helm package and changed any existing stuff to use that.
@hiddeco let me know what other changes you envisage here, one thing we could do and I am unsure about is return the actual values on the Chart and not just a checksum, but given we are not using them for anything else the checksum might be the simplest route.