This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Add manifest-generating API for installation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the |
2opremio
force-pushed
the
install-api
branch
3 times, most recently
from
51b3faa to
95dd2f5
Compare
|
No, it was unintentional. You are quick, it took me a couple of minutes to remove them :) |
|
I am going to need to tweak this further in order to support TLS. I can do it in another PR. @hiddeco thoughts? |
|
@2opremio I won't be able to review this until tomorrow. Can you work in a separate PR without this being merged? |
|
I won't continue working on this until tomorrow anyways |
|
Code looks alright to me (it is more or less the same as the existing code in the Flux codebase). One thing I noticed though is that you did not add the |
|
I forgot. Adding it right away. |
hiddeco
force-pushed
the
prepare-helm-op
branch
3 times, most recently
from
87f0a34 to
e6ea8c5
Compare
hiddeco
approved these changes
Aug 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to fluxcd/flux#2287 , this PR allows other Go programs to generate the Kubernetes manifests necessary to install the helm operator.
I plan to incorporate this into
fluxctl install --with-helm-op