This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
release: disable atomic flag for initial install #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it does not play nicely with some bootstrapping scenarios, enabling the (waiting) behaviour is still possible by setting `.spec.wait` to `true`.
|
Would it be reasonable to set |
|
@marshallford no, as the behaviour should not have been introduced to start with and the breaking change being made was actually using the |
|
I guess there was two breaking changes then, because I was relying on the |
|
It depends on the moment you started using the operator, but note that:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it does not play nicely with some bootstrapping scenarios, enabling the (waiting) behaviour is still possible by setting
.spec.waittotrue.Fixes #255