Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

docs: document usage of downloader plugins #295

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Feb 12, 2020

Closes: #266

@hiddeco hiddeco added the docs Issue or PR related to documentation label Feb 12, 2020
@hiddeco hiddeco force-pushed the docs/helm-downloader-plugins branch 2 times, most recently from dc41a59 to 0bb1f0a Compare February 12, 2020 22:20
@hiddeco hiddeco requested a review from stefanprodan February 12, 2020 22:29
@hiddeco hiddeco force-pushed the docs/helm-downloader-plugins branch from 0bb1f0a to 91b4441 Compare February 12, 2020 22:30
Copy link
Contributor

@stefansedich stefansedich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @hiddeco followed this end to end and everything worked, there were just a few typos that broke the copy+paste experience and the <x> placeholders were not immediately obvious to me.

docs/references/helmrelease-custom-resource.md Outdated Show resolved Hide resolved
docs/references/helmrelease-custom-resource.md Outdated Show resolved Hide resolved
docs/references/helmrelease-custom-resource.md Outdated Show resolved Hide resolved
docs/references/helmrelease-custom-resource.md Outdated Show resolved Hide resolved
@hiddeco hiddeco force-pushed the docs/helm-downloader-plugins branch from 91b4441 to 51ab23a Compare February 13, 2020 09:17
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiddeco hiddeco merged commit 05021eb into master Feb 13, 2020
@hiddeco hiddeco deleted the docs/helm-downloader-plugins branch February 13, 2020 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Issue or PR related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: provide examples of Helm (getter) plugins
3 participants