This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
status: unset rolledback cond on released=true #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the condition is always reset when a successful installation or upgrade happens, and prevents spurious upgrades from happening due to the rollback condition not being removed after a rolled back release was manually uninstalled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the condition is always reset when a successful
installation or upgrade happens, and prevents spurious upgrades
from happening due to the rollback condition not being removed
after a rolled back release was manually uninstalled.
Fixes behaviour reported in https://weave-community.slack.com/archives/C4U5ATZ9S/p1583248546169800