This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Make update interval a configurable flag #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swade1987
approved these changes
Sep 19, 2019
As in clusters that have many `HelmRelease` resources, the hardcoded default would put too much pressure on `etcd` due to Tiller collecting information. By making the interval a configurable flag, people can tweak the value to find the right balance of (non) pressure and observability.
hiddeco
force-pushed
the
update-interval-conf
branch
from
9a48227 to
91c0b11
Compare
|
@stefanprodan given we do not have an 'additional args' value in the Helm chart as we have in the Flux one; do you think adding this to the chart as a dedicated flag is desired, or would you vote for adding an 'additional args' value to the chart instead? |
|
I would go with a dedicated flag. |
Plus some reformatting, and documenting of other missing flags.
hiddeco
force-pushed
the
update-interval-conf
branch
from
04a98b0 to
59fab1c
Compare
stefanprodan
approved these changes
Sep 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in clusters that have many
HelmReleaseresources, the hardcodeddefault would put too much pressure on
etcddue to Tiller collectinginformation. By making the interval a configurable flag, people can
tweak the value to find the right balance of (non) pressure and
observability.
Image for testing available as
hiddeco/helm-operator:update-interval-conf-9a48227b