This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Ensure generated template modtime is Unix epoch #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsfgen which we use for maintaining an embedded copy of our templates does also include the modtime of the files. This poses a problem in combination with git, as in a project managed by git the modtime of a file depends on the time it was changed through a local git action (e.g. a checkout from a different state which results in a file write on disk) instead of the time of the actual change. This commit adds a wrapper around `http.FileSystem` that modifies the file mod times to always return Unix epoch. So that the only things resulting in a new `generated_template.gogen.go` are folder and/or file content changes.
stefanprodan
approved these changes
Sep 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vsfgen which we use for maintaining an embedded copy of our templates
does also include the modtime of the files.
This poses a problem in combination with git, as in a project managed
by git the modtime of a file depends on the time it was changed
through a local git action (e.g. a checkout from a different state
which results in a file write on disk) instead of the time of the
actual change.
This commit adds a wrapper around
http.FileSystemthat modifiesthe file mod times to always return Unix epoch. So that the only
things resulting in a new
generated_template.gogen.goare folderand/or file content changes.