Check for a nil lastTime before use

[Nalum]

Fix: #246

Avoiding a nil-deref by checking the lastTime variable before using it.

[Nalum]

Not too sure about how to test this, happy to get some pointers.

[pjbgf]

Not too sure about how to test this, happy to get some pointers.

I can't see an easy way to test it, apart from extracting the if-else block of code into its own function and creating a unit test just for it.

[Nalum]

I can't see an easy way to test it, apart from extracting the if-else block of code into its own function and creating a unit test just for it.

I can look at doing this but is seems a little overkill to me.

[pjbgf]

I can look at doing this but is seems a little overkill to me.

agreed, besides the ongoing refactoring may help on that front too.

on a side point, I added a nit comment about simplifying the if logic for clarity.

[pjbgf]

Nice one @Nalum, thank you for your contribution. 🙇

LGTM

[Nalum]

Thanks for your help and patience @pjbgf 👍

[stefanprodan]

@Nalum please squash all commits into a single one.

[hiddeco]

LGTM. Thank you @Nalum 🥇