Configure libgit2 fetch and push ProxyOptions #285
Conversation
au2001
force-pushed
the
http-auto-proxy-dev
branch
from
6c8d6a1
to
33ea33f
Compare
au2001
force-pushed
the
http-auto-proxy-dev
branch
2 times, most recently
from
08878c7
to
01143b2
Compare
|
libgit2/git2go#872 has been merged and backported to release-1.1 in libgit2/git2go@a800947 as v31.7.6 earlier today. I had to bump the version of git2go from v31.6.1 to v31.7.6 which contains the new push proxy options. I hope that's not an issue, given that there are no breaking changes documented between those two versions. @hiddeco Do you want me to implement similar test cases than the ones for fluxcd/source-controller#524, or are the tests in that PR sufficient? |
|
@au2001 Thanks a lot for adding the support in upstream git2go. Good to see that there's already a release available for it.
I don't think we need that. We have tests now in SC that helped us understand what works and what doesn't. We don't have any proxy test that performs any writing operations. It may be useful to have such tests in SC, along with other proxy tests. I wouldn't hold this change for that.
That shouldn't be an issue. We should also update the git2go version in SC. |
|
@au2001 could you rebase this against the main branch? |
Signed-off-by: Aurélien GARNIER <aurelien.garnier@atos.net>
au2001
force-pushed
the
http-auto-proxy-dev
branch
from
01143b2
to
9b82e81
Compare
|
@darkowlzz I have now rebased it with the latest commits from the main branch. |
Similarly to fluxcd/source-controller#524, this PR allows to specify an HTTP(S) proxy for Git operations through environment variables.
Fixes #279.
This is a draft for now because the current version of git2go's bindings do not allow to specify ProxyOptions for push operations, only for clone and fetch.
It first requires libgit2/git2go#872 to be merged and backported to release-1.1 (v31), which is the version of libgit2 used by image-automation-controller (and source-controller).