Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update source-controller to v0.22.4 #337

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Update source-controller to v0.22.4 #337

merged 1 commit into from
Mar 28, 2022

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Mar 28, 2022

Updates source-controller to v0.22.4 to fix known-issues in managed transport:

  • ssh.Dial hangs indefinitely
  • HTTP leaked connections
  • SSH leaked connections
  • Intermittent SSH errors
  • Panic when closing SSH connections

In addition, this PR frees a reference to repo.Head that was introduced on commit 4b35fe3.

Update source-controller to v0.22.4
859a6ca 
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@pjbgf pjbgf mentioned this pull request Mar 28, 2022
Closed
darkowlzz
darkowlzz approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pjbgf pjbgf merged commit b477df3 into fluxcd:main Mar 28, 2022
@pjbgf pjbgf deleted the update-sc-v0.22.4 branch March 28, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkowlzz darkowlzz darkowlzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Maintainers' Focus
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Experimental Managed Transport - Known Issues
2 participants
@pjbgf @darkowlzz