Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth for "https:" not found #146

Closed
somtochiama opened this issue May 17, 2021 · 5 comments · Fixed by #185
Closed

auth for "https:" not found #146

somtochiama opened this issue May 17, 2021 · 5 comments · Fixed by #185
Assignees

Comments

@somtochiama
Copy link
Member

Creating an Image repository with this YAML

apiVersion: image.toolkit.fluxcd.io/v1alpha2
kind: ImageRepository
metadata:
  name: inspector
  namespace: flux-system
spec:
  image: https://quay.io/repository/adoreme/inspector
  interval: 1m0s
  secretRef:
    name: quay-secret

and this docker-registry secret

{"auths":{"https://quay.io":{"username":"****","password":"****","auth":"****"}}}

results in this error

auth for "https:" not found in secret flux-system/quay-secret

This issue is gotten from this message on slack

@squaremo
Copy link
Member

The string given in the image: field is not a valid image ref -- there should not be a scheme (https://). It is an easy mistake to make, because image refs do include a hostname and a path. If we can detect this mistake, we can either correct for it or flag it specifically in an error.

@stefanprodan
Copy link
Member

@relu could you help out with this? I think we should parse the image URI and error out in a meaningful way.

@relu relu self-assigned this May 25, 2021
@mihaisee
Copy link

Indeed, removing the https:// fixed my issue. I think a heads up in the docs or a better error message as @squaremo suggested should do it.
From my part you guys can close this issue.
Great job and thanks for the help 👍

@kingdonb
Copy link
Member

Thanks for following up on this, I'm going to go ahead and close it.

@kingdonb
Copy link
Member

Sorry, I did not see that there was an assignment already here.

@kingdonb kingdonb reopened this Aug 19, 2021
relu added a commit that referenced this issue Oct 25, 2021
Adds a descriptive error when an invalid image ref containing a scheme
is given to the ImageRepository.

Fixes #146

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
relu added a commit that referenced this issue Oct 27, 2021
Adds a descriptive error when an invalid image ref containing a scheme
is given to the ImageRepository.

Fixes #146

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
relu added a commit that referenced this issue Oct 27, 2021
Adds a descriptive error when an invalid image ref containing a scheme
is given to the ImageRepository.

Fixes #146

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
relu added a commit that referenced this issue Oct 27, 2021
Adds a descriptive error when an invalid image ref containing a scheme
is given to the ImageRepository.

Fixes #146

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
relu added a commit that referenced this issue Oct 27, 2021
Adds a descriptive error when an invalid image ref containing a scheme
is given to the ImageRepository.

Fixes #146

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
relu added a commit that referenced this issue Nov 30, 2021
Adds a descriptive error when an invalid image ref containing a scheme
is given to the ImageRepository.

Fixes #146

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
@relu relu closed this as completed in #185 Dec 1, 2021
tomhuang12 pushed a commit to tomhuang12/image-reflector-controller that referenced this issue Jan 5, 2022
Adds a descriptive error when an invalid image ref containing a scheme
is given to the ImageRepository.

Fixes fluxcd#146

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants