Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement numerical ordering policy #104

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Implement numerical ordering policy #104

merged 1 commit into from
Feb 11, 2021

Conversation

relu
Copy link
Member

@relu relu commented Feb 11, 2021

Converts the given list of tags to floats and compares them based on the
ordering rule.
If a tag is not convertible, it will err and fail to compute the latest
version.

Fixes #102

@relu relu force-pushed the numerical-policy branch 2 times, most recently from c05ecda to 77d52fe Compare February 11, 2021 07:43
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @relu 🥇

I can do a followup PR to update the API spec docs and examples.

Converts the given list of tags to floats and compares them based on the
ordering rule.
If a tag is not convertible, it will err and fail to compute the latest
version.

Fixes #102

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
@stefanprodan stefanprodan added the enhancement New feature or request label Feb 11, 2021
@stefanprodan stefanprodan merged commit d4a4c29 into main Feb 11, 2021
@stefanprodan stefanprodan deleted the numerical-policy branch February 11, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend image policy with numerical ordering
3 participants