Make concurrent reconciliation configurable #153
Conversation
Default for both, the ImageRepository and the ImagePolicy controllers is 4 workers. closes fluxcd#148 Signed-off-by: Max Jonas Werner <mail@makk.es>
|
Looking good, @makkes! One suggestion I have, for consistency's sake, I think it would make sense to define some types named |
Yeah, I saw these in the other controllers and was wondering why these were different. If you don't mind, I'll introduce these types in a subsequent PR to keep this focussed on the reconciliation configurability. What do you think? |
|
@makkes it's ok to introduce the |
Alright, I'll add a commit shortly. |
This is in alignment with other controllers such as the helm-controller. Signed-off-by: Max Jonas Werner <mail@makk.es>
makkes
force-pushed
the
concurrent-reconciles
branch
from
cdac70a
to
03043e5
Compare
|
@relu @stefanprodan added option types for both controllers. |
sure thing |
| @@ -77,6 +78,7 @@ func main() { | |||
| "Watch for custom resources in all namespaces, if set to false it will only watch the runtime namespace.") | |||
| flag.StringVar(&storagePath, "storage-path", "/data", "Where to store the persistent database of image metadata") | |||
| flag.Int64Var(&storageValueLogFileSize, "storage-value-log-file-size", 1<<28, "Set the database's memory mapped value log file size in bytes. Effective memory usage is about two times this size.") | |||
| flag.IntVar(&concurrent, "concurrent", 4, "The number of concurrent resource reconciles.") | |||
There was a problem hiding this comment.
I think this flag definition comes from elsewhere; but either way, it deserves a better description, on two counts:
- it's the maximum number of workers
- "reconciles" doesn't tell the user what it affects.
Something like "The maximum number of scans that can run concurrently" would be an improvement, I reckon. WDYT?
There was a problem hiding this comment.
Oh it was merged already. OK never mind.
There was a problem hiding this comment.
@squaremo I agree. I'll come up with a follow-up PR.
There was a problem hiding this comment.
We could extract this into fluxcd/pkg/runtime like we did with the log level and other common flags. The description used here is the same for all the others controllers, better to change it in one place.
Default for both, the ImageRepository and the ImagePolicy controllers
is 4 workers.
fix: #148
Signed-off-by: Max Jonas Werner mail@makk.es