Clarify ECR Auto-login note, fix CanonicalImageName typos #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingdonb
commented
Jan 14, 2022
|
It will be hard to make more progress on this PR before fluxcd/website#702 is merged (and in turn, #194), so it can be reviewed in context. |
relu
previously requested changes
Jan 20, 2022
kingdonb
force-pushed
the
docs-patches
branch
from
d931bb8
to
d79b2b8
Compare
|
Rebased to get this in shape to merge 👍 |
kingdonb
force-pushed
the
docs-patches
branch
2 times, most recently
from
c0f70c1
to
d61c863
Compare
Link to the Image Update guide When fluxcd/website#702 merges, this patch will have been incorporated into the Image Update Guide. Add a link to the more directly relevant Image Update Guide here instead, since it has the example, and it doesn't belong in the API docs nor need to be repeated here, per the discussion from the earlier PR number fluxcd#193. Signed-off-by: Kingdon Barrett <kingdon@weave.works> remove orphaned link URLs Signed-off-by: Kingdon Barrett <kingdon@weave.works> Signed-off-by: Kingdon Barrett <yebyen@gmail.com>
kingdonb
force-pushed
the
docs-patches
branch
from
d61c863
to
968f79f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leans on:
(but I think they can merge in either order)
Slimmed-down replacement version of #193 that takes into account most other things that were to be fixed here, are fixed by fluxcd/website#702
There was a usability issue reported in the docs that I meant to address here, and it's not obvious from the structure of the change, but as the
ImageRepositoriescontroller API docs are not obviously associated with theimage-reflector-controllerwhere they are most accessible (on the website, here in the API docs)There is no breadcrumb which says
image-reflector-controllervisible anywhere on the page, so it's necessary to spell out which controller needs to get the flag.In fluxcd/website#702 a detailed guide is added that covers ECR, as well as the other cloud providers, and so this PR can omit the example of how to set up the patch in deference to a link to the guide instead. 👍