GCR fix: Discard and close body regardless of status code #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
|
(I think the CI is failing because there's a stray space that gets gofmt'd out, meaning the "is the working tree dirty?" check fails) |
squaremo
approved these changes
Jan 20, 2022
somtochiama
force-pushed
the
gcp-autologin
branch
from
82da654 to
51c97e2
Compare
stefanprodan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little follow-up on the #194 to ensure the response body is closed regardless of status code
Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com