Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclusionList to enable excluding tags based on regex. #256

Merged
merged 2 commits into from
May 11, 2022

Conversation

aryan9600
Copy link
Member

@aryan9600 aryan9600 commented May 10, 2022

ExlusionList specifies a list of regex expressions, which is used to
filter out unwanted tags from being stored in the database. If the list
is empty, by default all tags ending with .sig are ignored.

Fixes #167

Signed-off-by: Sanskar Jaiswal jaiswalsanskar078@gmail.com

ExlusionList specifies a list of regex expressions, which is used to
filter out unwanted tags from being stored in the database. If the list
is empty, by default all tags ending with `.sig` are ignored.

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need tests to make sure the default is used when no list is provided, and that the default is ignored when a list is provided.

Makefile Show resolved Hide resolved
controllers/imagerepository_controller.go Outdated Show resolved Hide resolved
@stefanprodan
Copy link
Member

You forgot to link to the issue.

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@stefanprodan stefanprodan added the enhancement New feature or request label May 11, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @aryan9600 🏅

@stefanprodan stefanprodan merged commit b22fca4 into fluxcd:main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow exclusion of cosign objects from the image repository database
2 participants