Fix generation of kustomization.yaml for macOS if absent

Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>

controllers/kustomization_controller.go

@@ -300,7 +300,7 @@ func (r *KustomizationReconciler) reconcile(
 	revision := source.GetArtifact().Revision
 
 	// create tmp dir
-	tmpDir, err := os.MkdirTemp("", "kustomization-")
+	tmpDir, err := CreateAbsTempDir()
 	if err != nil {
 		err = fmt.Errorf("tmp dir error: %w", err)
 		return kustomizev1.KustomizationNotReady(
@@ -310,7 +310,6 @@ func (r *KustomizationReconciler) reconcile(
 			err.Error(),
 		), err
 	}
-	defer os.RemoveAll(tmpDir)
 
 	// download artifact and extract files
 	err = r.download(source.GetArtifact(), tmpDir)

controllers/utils.go

@@ -0,0 +1,25 @@
+package controllers
+
+import (
+	"fmt"
+	"os"
+	"path/filepath"
+)
+
+// CreateAbsTempDir creates a tmp dir and returns the absolute path to the dir.
+// This is required since macOS creates temporary files in
+// `/private/var` to which `/var` is a symlink to.
+func CreateAbsTempDir() (string, error) {
+	// create tmp dir
+	tmpDir, err := os.MkdirTemp("", "kustomization-")
+	defer os.RemoveAll(tmpDir)
+	if err != nil {
+		return "", err
+	}
+
+	tmpDir, err = filepath.EvalSymlinks(tmpDir)
+	if err != nil {
+		return "", fmt.Errorf("error evaluating symlink: %w", err)
+	}
+	return tmpDir, nil
+}