Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fluxcd/pkg/ssa to exclude the status field from apply #533

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Update fluxcd/pkg/ssa to exclude the status field from apply #533

merged 1 commit into from
Jan 13, 2022

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Jan 13, 2022 •
edited
Loading

Depends on: fluxcd/pkg#217
Fixes: #532

Test this PR using ghcr.io/fluxcd/kustomize-controller:rc-6e0d0550.

To use the release candidate on your cluster, add the following image patch to clusters/<cluster>/flux-system/kustomization.yaml:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- gotk-components.yaml
- gotk-sync.yaml
images:
  - name: ghcr.io/fluxcd/kustomize-controller
    newName: ghcr.io/fluxcd/kustomize-controller
    newTag: rc-6e0d0550

@stefanprodan stefanprodan requested a review from hiddeco January 13, 2022 14:56
hiddeco
hiddeco approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise this looks OK to me, but have not taken it for a spin to actually test the RC.

relu
relu approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@relu relu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@stefanprodan stefanprodan mentioned this pull request Jan 13, 2022
Closed
1 task
@stefanprodan
Update fluxcd/pkg/ssa to exclude the status field from apply
02c6708 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan merged commit f39a771 into main Jan 13, 2022
@stefanprodan stefanprodan deleted the ssa-exclude-status branch January 13, 2022 17:17
@stefanprodan stefanprodan added the area/server-side-apply SSA related issues and pull requests label Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

@relu relu relu approved these changes

Assignees
No one assigned
Labels
area/server-side-apply SSA related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StatefulSets error: .status.availableReplicas: field not declared in schema
3 participants
@stefanprodan @relu @hiddeco