Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Azure Devops notifier issues #154

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Fix Azure Devops notifier issues #154

merged 1 commit into from
Mar 5, 2021

Conversation

phillebaba
Copy link
Member

This change contains general fixes to the Azure DevOps notifier to fix smaller usability issues.

  • Respect schema set by the provider url
  • Modify the Azure DevOps notifier to allow compatibility with running behind a proxy.
  • Check existing commit statuses to avoid spamming the same status when reconciling.

Signed-off-by: Philip Laine philip.laine@xenit.se

Modify the Azure DevOps notifier to allow compatibiliy
with running behind a proxy.
Check existing commit statuses to avoid spamming the
same status when reconciling.

Signed-off-by: Philip Laine <philip.laine@xenit.se>
@phillebaba phillebaba changed the title Respect schema set by the provider url Fix Azure Devops notifier issues Mar 5, 2021
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @phillebaba 🥇

@phillebaba phillebaba merged commit d79f88b into main Mar 5, 2021
@phillebaba phillebaba deleted the fix/azuredevops branch March 5, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants