Add support for Azure EventHub provider #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
reviewed
May 3, 2021
| } | ||
|
|
||
| // Post all notification-controller messages to EventHub | ||
| func (e *AzureEventHub) Post(event events.Event) error { |
There was a problem hiding this comment.
Doesn't really matter, but maybe change the variable from e to a
Solves #190 Signed-off-by: Edvin Norling <edvin.norling@xenit.se>
* Update go.sum * Use ctx with timeout * minor linting & clean-up Signed-off-by: Edvin Norling <edvin.norling@xenit.se>
Depending if endpointURL starts with Endpoint or not we assume that it's a JWT token or not. Making sure that the JWT token is up to date is NOT the notifcation-controllers work Signed-off-by: Edvin Norling <edvin.norling@xenit.se>
For JWT * channel = eventhub namespace * address = eventhub name * token = jwt token For SAS * address = connectionString, including endpoint tokens etc Signed-off-by: Edvin Norling <edvin.norling@xenit.se>
Signed-off-by: Edvin Norling <edvin.norling@xenit.se>
|
@NissesSenap please run |
Signed-off-by: Edvin Norling <edvin.norling@xenit.se>
phillebaba
previously approved these changes
May 5, 2021
added 2 commits
May 5, 2021 16:39
* Add secret example for SAS and JWT Signed-off-by: Edvin Norling <edvin.norling@xenit.se>
* Change name of var eventhubNamespace to eventhubNamespace Signed-off-by: Edvin Norling <edvin.norling@xenit.se>
| export AZURE_SECRET='secret-client-secret-generated-at-creation' | ||
| export AZURE_TENANT=$(az account show -o tsv --query tenantId) | ||
|
|
||
| curl -X GET --data 'grant_type=client_credentials' --data "client_id=$AZURE_CLIENT" --data "client_secret=$AZURE_SECRET" --data 'resource=https://eventhubs.azure.net' -H 'Content-Type: application/x-www-form-urlencoded' https://login.microsoftonline.com/$AZURE_TENANT/oauth2/token |jq .access_token |
There was a problem hiding this comment.
There was a problem hiding this comment.
This will use your account instead of the application account. Risk of giving to much access, I would recomend to use this way.
Signed-off-by: Edvin Norling <edvin.norling@xenit.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #190