Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discord: Remove username and channel requirements #324

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

vchrisb
Copy link
Contributor

@vchrisb vchrisb commented Feb 8, 2022

Fixes #323

Changes:

  • username optional
  • channel optional and remove it from payload

@vchrisb vchrisb force-pushed the discord_properties branch 2 times, most recently from 2b57d91 to 2c251ea Compare February 8, 2022 09:50
* username optional
* channel optional and remove it from payload

Signed-off-by: Christopher Banck <christopher@banck.net>
@vchrisb vchrisb force-pushed the discord_properties branch from 2c251ea to f365f37 Compare February 8, 2022 09:54
Signed-off-by: Christopher Banck <christopher@banck.net>
@stefanprodan stefanprodan changed the title update discord properties discord: Remove username and channel requirements Feb 9, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @vchrisb

@stefanprodan stefanprodan added the area/alerting Alerting related issues and PRs label Feb 9, 2022
@stefanprodan stefanprodan merged commit bf33786 into fluxcd:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Alerting related issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

discord provider properties
2 participants