Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return err on invalid UTF-8 character in token #361

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Return err on invalid UTF-8 character in token #361

merged 2 commits into from
Apr 19, 2022

Conversation

somtochiama
Copy link
Member

Closes: #360

Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com

Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@somtochiama somtochiama marked this pull request as draft April 8, 2022 14:12
@somtochiama somtochiama marked this pull request as ready for review April 8, 2022 14:15
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@stefanprodan stefanprodan added the area/alerting Alerting related issues and PRs label Apr 9, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama 🏅

@hiddeco hiddeco merged commit d2e3670 into main Apr 19, 2022
@hiddeco hiddeco deleted the gitlab-status branch April 19, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Alerting related issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non UTF-8 in token should not panic
3 participants