Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages for alert providers #375

Merged
merged 1 commit into from
May 22, 2022
Merged

Conversation

somtochiama
Copy link
Member

This pull request adds the error from parsing provider URLs to the returned error message.
This would be helpful in debugging issues and understanding why the URL might be invalid.

Ref: discussion#2719

Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com

Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@somtochiama somtochiama changed the title Better error messages for providers Better error messages for alert providers May 19, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama 🌷

@stefanprodan stefanprodan added enhancement New feature or request area/alerting Alerting related issues and PRs labels May 22, 2022
@stefanprodan stefanprodan merged commit a395873 into main May 22, 2022
@stefanprodan stefanprodan deleted the error-msg-providers branch May 22, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Alerting related issues and PRs enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants