Add support for PagerDuty #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makkes
reviewed
May 12, 2023
makkes
reviewed
May 12, 2023
|
Thanks for this PR @MartiUK ! |
|
Hi @makkes, @stefanprodan is there anything else needed to progress this PR further? |
makkes
reviewed
Jun 22, 2023
|
Please resolve the conflicts with |
MartiUK
force-pushed
the
pagerduty
branch
3 times, most recently
from
1bdba27
to
5fa67ce
Compare
|
Your generated CRD manifests don't match the code. Please run |
MartiUK
force-pushed
the
pagerduty
branch
2 times, most recently
from
c029a27
to
22c1a39
Compare
stefanprodan
added
enhancement
makkes
force-pushed
the
pagerduty
branch
2 times, most recently
from
34fca2e
to
090038c
Compare
Signed-off-by: Martin Kemp <me@martinke.mp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for PagerDuty.
There are some assumptions made in regards to what should trigger an incident, I'm happy to be corrected on this.
It would be nice to allow Alerts to override some Provider settings e.g. override the channel (integration key) to send alerts to different PagerDuty integrations without needed to create a Provider for each.