Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include eventv1.MetaTokenKey on event rate limiting key calculation #530

Merged
merged 1 commit into from
May 24, 2023
Merged

Include eventv1.MetaTokenKey on event rate limiting key calculation #530

merged 1 commit into from
May 24, 2023

Conversation

matheuscscp
Copy link
Collaborator

Part of fixing fluxcd/helm-controller#678

Supersedes #518

@matheuscscp matheuscscp mentioned this pull request May 19, 2023
Closed
hiddeco
hiddeco reviewed May 22, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@hiddeco hiddeco added the hold Issues and pull requests put on hold label May 22, 2023
@matheuscscp @hiddeco
Include eventv1.MetaTokenKey on event rate limiting key calculation
4e05bc8 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@hiddeco hiddeco added enhancement New feature or request and removed hold Issues and pull requests put on hold labels May 24, 2023
@stefanprodan stefanprodan mentioned this pull request May 24, 2023
Closed
10 tasks
stefanprodan
stefanprodan approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiddeco hiddeco merged commit d8254c3 into fluxcd:main May 24, 2023
@matheuscscp matheuscscp deleted the rate-limit-token branch May 24, 2023 10:05
@hiddeco hiddeco mentioned this pull request May 24, 2023
Merged
@matheuscscp matheuscscp mentioned this pull request May 26, 2023
Closed
6 tasks
@stefanprodan stefanprodan mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matheuscscp @stefanprodan @hiddeco