Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Provider for NATS Subject #651

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Conversation

SkullKidCode
Copy link
Contributor

@SkullKidCode SkullKidCode commented Nov 26, 2023

Fixes #470

Adds support to send events to a NATS subject. Supports authentication through Username/Password as well.

Due the similarities in architecture with Google Pub/Sub, I drew inspiration for the implementation and testing of this change from that provider.

Signed-off-by: Toby Watson <SkullKidCode@users.noreply.github.com>
@SkullKidCode
Copy link
Contributor Author

Updated to add the new provider to v1beta3 instead since I see it has just been added :D

@stefanprodan stefanprodan added enhancement New feature or request area/alerting Alerting related issues and PRs labels Dec 1, 2023
Co-authored-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: SkullKidCode <SkullKidCode@users.noreply.github.com>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @SkullKidCode 🏅

@stefanprodan stefanprodan merged commit bf58d33 into fluxcd:main Dec 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Alerting related issues and PRs enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NATS as a notifier
2 participants