Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for providers and alerts #74

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Conversation

stefanprodan
Copy link
Member

Validate providers and alerts and report the validation errors in the status sub-resource.

Fix: #72

@stefanprodan stefanprodan added enhancement New feature or request area/alerting Alerting related issues and PRs labels Nov 9, 2020
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Copy link
Member

@phillebaba phillebaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice job with the validation!

Should we skip alerts and providers in the event handler in the same way we do with suspended alerts?

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Copy link
Member

@phillebaba phillebaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanprodan stefanprodan merged commit 802667a into main Nov 9, 2020
@stefanprodan stefanprodan deleted the alert-validation branch November 9, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Alerting related issues and PRs enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

leaving channel unset silently breaks Slack provider
2 participants