git/gogit: modify chroot to return a new os filesystem #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
reviewed
Nov 28, 2022
Modify `Chroot()` into returning a new OS filesystem. The filesystem returned is not actually chrooted, but only enforces all files to be under the root working directory. This is required to avoid breaking cloning repos with submodules. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
Chroot()into returning a new OS filesystem. The filesystem returned is not actually chrooted, but only enforces all files to be under the root working directory. This is required to avoid breaking cloning repos with submodules. Ref: https://github.com/fluxcd/go-git/blob/d979ddd67ae30aebcdd285c0b0133594e7194980/storage/filesystem/dotgit/dotgit.go#L1100-L1103Related to: fluxcd/source-controller#970
Signed-off-by: Sanskar Jaiswal jaiswalsanskar078@gmail.com