Skip to content

Commit

Permalink
libgit2: remove connection caching
Browse files Browse the repository at this point in the history
Connection caching was a feature created to resolve
upstream issues raised from concurrent ssh connections.
Some scenarios were based on multiple key exchange
operations happening at the same time.

This PR removes the connection caching, and instead:
- Services Session.StdoutPipe() as soon as possible,
  as it is a known source of blocking SSH connections.
- Reuse SSH connection within the same subtransport,
  eliminating the need for new handshakes when talking
  with the same server.
- Simplifies the entire transport logic for better
  maintainability.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
  • Loading branch information
Paulo Gomes committed May 12, 2022
1 parent 9c1bbc4 commit 1df3236
Show file tree
Hide file tree
Showing 2 changed files with 64 additions and 324 deletions.
Loading

0 comments on commit 1df3236

Please sign in to comment.